vmware_vm_info: Add allocated Storage, CPU and Memory to output #1283
Conversation
Nina2244
changed the title
plugins/modules/vmware_vm_info.py
Outdated
| PyVmomi, get_all_objs, | ||
| vmware_argument_spec, _get_vm_prop, | ||
| get_parent_datacenter, find_vm_by_name) | ||
| from ansible_collections.community.vmware.plugins.module_utils.vmware import PyVmomi, get_all_objs, vmware_argument_spec, _get_vm_prop, get_parent_datacenter, find_vm_by_name |
There was a problem hiding this comment.
ERROR: plugins/modules/vmware_vm_info.py:246:161: E501: line too long (174 > 160 characters)
plugins/modules/vmware_vm_info.py
Outdated
| "storage": storage_allocated, | ||
| "cpu": vm.config.hardware.numCPU, | ||
| "memory": vm.config.hardware.memoryMB | ||
| } |
There was a problem hiding this comment.
ERROR: plugins/modules/vmware_vm_info.py:340:17: E123: closing bracket does not match indentation of opening bracket's line
plugins/modules/vmware_vm_info.py
Outdated
| if isinstance(device, vim.vm.device.VirtualDisk): | ||
| storage_allocated += device.capacityInBytes | ||
|
|
||
| allocated = { |
There was a problem hiding this comment.
Add a flag to return these facts optionally (for example - show_allocated ) rather than always returning facts.
There was a problem hiding this comment.
Yes I will do this.
Add a posibility to show or not to show the allocation.
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 3m 52s |
SUMMARY
Add allocated Storage, CPU and Memory to output
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
vmware_vm_info.py
ADDITIONAL INFORMATION